Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UnderlineNav-item to not wrap counter & icon #1035

Merged
merged 2 commits into from
Mar 24, 2020

Conversation

jonrohan
Copy link
Member

I'm running into the situation where the underline nav items will wrap counter and icon items at certain screen sizes.

image

I want to add a no wrap rule to each UnderlineNav-item so that the elements don't wrap like this.

@jonrohan jonrohan requested a review from simurai February 21, 2020 18:00
@vercel
Copy link

vercel bot commented Feb 21, 2020

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/emjd1qjol
✅ Preview: https://primer-css-git-underlinenav-item-nowrap.primer.now.sh

@vercel vercel bot temporarily deployed to Preview February 23, 2020 03:08 Inactive
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

What's the urgency to ship it on dotcom? Maybe we can do another release together with #1028.

@jonrohan
Copy link
Member Author

What's the urgency to ship it on dotcom? Maybe we can do another release together with

It's not super urgent at the moment, I'm using a no-wrap utility. So i'm ok for it to go out with whatever next release is coming up

@simurai simurai changed the base branch from master to release-14.3.0 March 24, 2020 01:40
@simurai simurai merged commit 3f3caad into release-14.3.0 Mar 24, 2020
@simurai simurai deleted the underlinenav-item-nowrap branch March 24, 2020 01:40
@simurai simurai mentioned this pull request Mar 27, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants