Component refresh tweaks III

[simurai]

Here a few more "Component refresh" tweaks

Buttons

There are some changes to the primary and outline buttons:

Before

After

Sizes

This PR also reverts using only line-height for setting a component's height and instead uses again a mix of line-height and padding (and border). There are some places on dotcom that use custom padding and would blow them up too much with a large line-height.

The buttons are still only 32px in height (instead of 34px) so it matches our sizing scale. It leaves the line-height unchanged to 20px but uses 5px y-padding instead of 6px.

👀 Preview

[vercel]

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/akk8brezm
✅ Preview: https://primer-css-git-next-3.primer.now.sh

[jonrohan]

I see you deleting the docs here, but I didn't see Counter--small deleted in the css. Missed or already deleted before?

[simurai]

Yep, the .Counter--small doesn't exist anymore and I just forgot to remove it from the docs. We might can consider adding a .Counter--large if we ever need it.