-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing rounded-3 utility #1156
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-css/aqcneijd4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@esdraspavon Thanks for the addition. 🙇
Just realized we also have utility classes for each edge:
css/src/utilities/borders.scss
Lines 55 to 71 in c752b4e
.rounded#{$variant}-#{$edge}-1 { | |
@each $corner in $corners { | |
border-#{$corner}-radius: $border-radius / 2 !important; | |
} | |
} | |
.rounded#{$variant}-#{$edge}-2 { | |
@each $corner in $corners { | |
border-#{$corner}-radius: $border-radius !important; | |
} | |
} | |
.rounded#{$variant}-#{$edge}-3 { | |
@each $corner in $corners { | |
border-#{$corner}-radius: $border-radius * 2 !important; | |
} | |
} |
Maybe we should use the $border-radius-[1-3]
variables too instead of / 2
and * 2
so the values match?
@simurai np! sounds good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ Thanks 🙇
Closes #1154
/cc @primer/ds-core