Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scss-lint properties for v0.38.0 #118

Merged
merged 10 commits into from
Jun 1, 2015
Merged

Conversation

jonrohan
Copy link
Member

We’ve updated our scss_lint gem to the latest version, and this
required us to update some of the properties here. We also added and
turned off new ones.

This pull updates the config to keep in line with the rest of our
codebase.

@mdo @primer/owners

We’ve updated our scss_lint gem to the latest version, and this
required us to update some of the properties here. We also added and
turned off new ones.

This pull updates the config to keep in line with the rest of our
codebase.
@jasonlong
Copy link
Contributor

Is the (re?)addition of the severity: errors specific to the upgrade? I thought we used to have those, but removed them at some point.

@jonrohan
Copy link
Member Author

Is the (re?)addition of the severity: errors specific to the upgrade?

yes our ci setup treats them all as warnings if it's not specified.

@jasonlong
Copy link
Contributor

👍 Cool, thx.


h4 + p.note {
margin-top: 0;
+ p.note {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid qualifying class selectors with an element.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning, ignore

It doesn't look like we can have warnings turned on for @houndci They
don’t treat them differently from errors. :(
@mdo mdo added this to the v2.2.0 milestone May 26, 2015
@mdo mdo added the css label May 26, 2015
@mdo
Copy link
Contributor

mdo commented May 26, 2015

Are all those Hound checks good to go then?

@jonrohan
Copy link
Member Author

Are all those Hound checks good to go then?

yeah ignore those.

mdo added a commit that referenced this pull request Jun 1, 2015
Update scss-lint properties for v0.38.0
@mdo mdo merged commit f4d4a12 into master Jun 1, 2015
@mdo mdo deleted the scss-lint-settings-upgrade branch June 1, 2015 18:30
@mdo mdo mentioned this pull request Jun 1, 2015
timv88 pushed a commit to timv88/primer that referenced this pull request Aug 12, 2015
…one_is_enter_my_name_Thrillhouse

Combining $codeFont and $monoFont
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants