-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scss-lint properties for v0.38.0 #118
Conversation
We’ve updated our scss_lint gem to the latest version, and this required us to update some of the properties here. We also added and turned off new ones. This pull updates the config to keep in line with the rest of our codebase.
Is the (re?)addition of the |
yes our ci setup treats them all as warnings if it's not specified. |
👍 Cool, thx. |
These are taken care of by autoprefixer right @mdo?
|
||
h4 + p.note { | ||
margin-top: 0; | ||
+ p.note { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid qualifying class selectors with an element.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning, ignore
It doesn't look like we can have warnings turned on for @houndci They don’t treat them differently from errors. :(
Are all those Hound checks good to go then? |
yeah ignore those. |
Update scss-lint properties for v0.38.0
…one_is_enter_my_name_Thrillhouse Combining $codeFont and $monoFont
We’ve updated our scss_lint gem to the latest version, and this
required us to update some of the properties here. We also added and
turned off new ones.
This pull updates the config to keep in line with the rest of our
codebase.
@mdo @primer/owners