Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump @primer/primitives #1262

Closed
wants to merge 2 commits into from
Closed

Bump @primer/primitives #1262

wants to merge 2 commits into from

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Mar 26, 2021

This bumps @primer/primitives to 4.0.2.

@changeset-bot
Copy link

changeset-bot bot commented Mar 26, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 8f3441b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Mar 26, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-css/Bw6czp5ZRM9o4AKUB2s29in4ZHPN
✅ Preview: https://primer-css-git-bump-primitives-primer.vercel.app

@vercel vercel bot temporarily deployed to Preview March 26, 2021 13:36 Inactive
simurai
simurai commented Mar 26, 2021
View reviewed changes
package.json
@@ -41,7 +41,7 @@
},
"dependencies": {
"@primer/octicons": "^9.1.1",
"@primer/primitives": "^4.0.1"
"@primer/primitives": "^4.0.2"
Copy link
Contributor Author

@simurai simurai Mar 26, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonrohan Do we even need to do this PR? With the ^ it should automatically install the latest version as long as it's not a major version with breaking changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should start saving exact versions like dotcom

@simurai simurai requested a review from jonrohan March 26, 2021 13:36
@jonrohan
Copy link
Member

Could probably deploy the sha package from here and bypass a release

@simurai
Copy link
Contributor Author

simurai commented Mar 26, 2021

I think we don't have bump @primer/primitives anymore.. when I npm install on main (without merging this PR) it already picks up the @primer/primitives@4.0.2. release:

Screen Shot 2021-03-26 at 22 53 45

@jonrohan
Copy link
Member

Closing this then

@jonrohan jonrohan closed this Mar 26, 2021
@jonrohan jonrohan deleted the bump-primitives branch March 26, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simurai @jonrohan