Inline error state styling #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| font-size: 13px; | ||
|
|
||
| &:after { | ||
| border-color: rgba(191, 21, 21, 0); |
There was a problem hiding this comment.
Is transparent enough for all these?
added 2 commits
June 24, 2015 14:09
|
@mdo, do we need to add these to the docs or are we good? What's the best way to do that since these are kinda js dependent? |
|
Words could use some work I think, but how's this?
|
|
I love it! |
|
Groovy. If this is good to merge for you then, fire away. |
aaronshekey
pushed a commit
that referenced
this pull request
Jun 24, 2015
Inline error state styling
timv88
pushed a commit
to timv88/primer
that referenced
this pull request
Aug 12, 2015
Remove nav pulse animation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After testing these changes on the new repo page of .com, I think these visual updates are ready to ship with Primer to affect all other portions of the site.
These are working in concert with our autocheck js.
Error
#### Warning