Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing v2 color mode css variable fallbacks #1579

Merged
merged 3 commits into from
Sep 9, 2021
Merged

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Sep 8, 2021

There weren't many, this removes the couple of v1 css variable fallbacks we had in the code.

var(--color-v2, var(--color-v1)) ➡️ var(--color-v2)

@jonrohan jonrohan requested a review from a team as a code owner September 8, 2021 17:17
@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2021

🦋 Changeset detected

Latest commit: ed4a69e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonrohan jonrohan changed the title Removing v2 color mode fallbacks Removing v2 color mode css variable fallbacks Sep 8, 2021
@jonrohan jonrohan enabled auto-merge (squash) September 8, 2021 21:14
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@jonrohan jonrohan merged commit c3b4a0c into main Sep 9, 2021
@jonrohan jonrohan deleted the cleanup_v2_fallbacks branch September 9, 2021 01:11
This was referenced Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants