Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat rgba() colors #1781

Merged
merged 3 commits into from
Dec 3, 2021
Merged

Reformat rgba() colors #1781

merged 3 commits into from
Dec 3, 2021

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Nov 30, 2021

This closes #1778 and prevent Jekyll to throw the following error:

/usr/gem/gems/jekyll-sass-converter-1.5.2/lib/jekyll/converters/scss.rb:123:in `rescue in convert': wrong number of arguments (1 for 4) for `rgba' on line 16 (Jekyll::Converters::Scss::SyntaxError)

@simurai simurai requested a review from a team as a code owner November 30, 2021 04:49
@changeset-bot
Copy link

changeset-bot bot commented Nov 30, 2021

🦋 Changeset detected

Latest commit: 1bc4dc4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@tobiasahlin tobiasahlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just standard functional color syntax - the Jekyll error being thrown here is from an old version (2018) of this gem. Latest is 2.1.0 → https://rubygems.org/gems/jekyll-sass-converter, could be worth verifying if this is a problem on newer versions before changing.

@svrooij
Copy link

svrooij commented Nov 30, 2021

This is just standard functional color syntax - the Jekyll error being thrown here is from an old version (2018) of this gem. Latest is 2.1.0 → https://rubygems.org/gems/jekyll-sass-converter, could be worth verifying if this is a problem on newer versions before changing.

It might be an old version, but version 1.5.2 is the one that is pulled in by github-pages according to github-pages gem. And there is nothing in the release notes suggesting that they implemented any other function parsing.

source 'https://rubygems.org'
gem 'github-pages', group: :jekyll_plugins
gem "jekyll-github-metadata"
gem "jekyll-octicons"
gem "jemoji"
gem "jekyll-paginate"

@simurai simurai enabled auto-merge (squash) December 3, 2021 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alternative formatting CSS code rgba (Jekyll sass doesn't like spaces)
4 participants