Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PageLayout API updated props + examples #1931

Merged
merged 11 commits into from
Feb 17, 2022
Merged

PageLayout API updated props + examples #1931

merged 11 commits into from
Feb 17, 2022

Conversation

vdepizzol
Copy link
Contributor

@vdepizzol vdepizzol commented Feb 4, 2022 •
edited
Loading

What are you trying to accomplish?

  • Rename innerSpacing and outerSpacing from PageLayout and SplitPageLayout storybook components to padding to match with API updates.
  • Fix Layout example stories
  • Add header and footer slots to SplitPageLayout
  • Add padding: none option to Layout components
  • Add Pull request detail page storybook example

What should reviewers focus on?

Are additional changes needed?

  • No, this PR should be ok to ship as is. 🚢

@changeset-bot
Copy link

changeset-bot bot commented Feb 4, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 043b743

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vdepizzol vdepizzol changed the title Page layout api updates PageLayout API updated props + examples Feb 4, 2022
@vdepizzol vdepizzol marked this pull request as ready for review February 10, 2022 04:33
@vdepizzol vdepizzol requested a review from a team as a code owner February 10, 2022 04:33
@vdepizzol vdepizzol merged commit e5c5312 into main Feb 17, 2022
@vdepizzol vdepizzol deleted the pageLayout-api-updates branch February 17, 2022 20:31
@primer-css primer-css mentioned this pull request Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

@jonrohan jonrohan jonrohan approved these changes

Assignees
No one assigned
Labels
patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vdepizzol @jonrohan @langermank