Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormControl + Autocomplete component updates #2075

Merged
merged 24 commits into from
May 26, 2022
Merged

FormControl + Autocomplete component updates #2075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
6c8c024
setup new tokens
langermank May 6, 2022
88b7d10
layout
langermank May 7, 2022
d4a3065
label positioning
langermank May 7, 2022
628251a
cleanup
langermank May 7, 2022
0111896
states
langermank May 7, 2022
75fc5e6
cleanup
langermank May 9, 2022
23af1fa
convert label to use grid for caption text (start)
langermank May 10, 2022
613bd93
begin checkbox/radio custom styles
langermank May 12, 2022
ccdf202
Merge branch 'main' of https://github.com/primer/css into form-contro…
langermank May 19, 2022
e6d21be
fix input grid (mostly)
langermank May 20, 2022
29b2a95
refactor + cleanup
langermank May 20, 2022
0157e0c
consolidate styles, start custom checkbox
langermank May 20, 2022
a247c38
cleanup
langermank May 20, 2022
711b6b6
Merge branch 'main' into form-control-component-updates
langermank May 20, 2022
68d7267
lint
langermank May 22, 2022
5a146ec
Merge branch 'form-control-component-updates' of https://github.com/p…
langermank May 22, 2022
8bcb0f1
add disabled state to actionlist-item
langermank May 22, 2022
c1fd9e4
adjust trailing action grid
langermank May 22, 2022
5713e66
Stylelint auto-fixes
actions-user May 22, 2022
7fc9afd
remove docs
langermank May 22, 2022
bec2fb8
Merge branch 'form-control-component-updates' of https://github.com/p…
langermank May 22, 2022
970dc62
add indeterminate checkbox styles
langermank May 26, 2022
f686541
Merge branch 'main' into form-control-component-updates
langermank May 26, 2022
81510ca
Create empty-drinks-report.md
langermank May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/empty-drinks-report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@primer/css": patch
---

FormControl + Autocomplete component updates
2 changes: 0 additions & 2 deletions docs/src/@primer/gatsby-theme-doctocat/nav.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@
children:
- title: Alerts
url: /components/alerts
- title: Autocomplete
url: /components/autocomplete
Comment on lines -49 to -50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 On just removing the nav item for now.

Internal discussion around not having to maintain documentation in PCSS AND PVC.

- title: Avatars
url: /components/avatars
- title: Blankslate
Expand Down
21 changes: 21 additions & 0 deletions src/actionlist/action-list-item.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,27 @@
}
}

// disabled
&[aria-disabled='true'] {
.ActionList-item-content {
.ActionList-item-label,
.ActionList-item-description {
color: var(--color-primer-fg-disabled);
}

.ActionList-item-visual {
fill: var(--color-primer-fg-disabled);
}

@media (hover: hover) {
&:hover {
cursor: not-allowed;
background-color: transparent;
}
}
}
}

// variants

// danger
Expand Down
3 changes: 3 additions & 0 deletions src/autocomplete/autocomplete.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// This file can be deprecated when AutoComplete is upstreamed to PVC + rolled out to dotcom https://github.com/github/primer/issues/796
// AutoComplete relies on FormControl, Overlay and ActionList CSS

// Stacked label (default)
.autocomplete-label-stacked {
display: block;
Expand Down
Loading