Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormControl + Overlay bug fixes #2124

Merged
merged 4 commits into from
Jun 17, 2022
Merged

FormControl + Overlay bug fixes #2124

merged 4 commits into from
Jun 17, 2022

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Jun 8, 2022

Accompanying PVC PR primer/view_components#1189

  • Fixes a fallback for a new design token causing no border (box-shadow) to appear
  • Adds z-index to all Overlay scenarios

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@langermank langermank requested a review from a team as a code owner June 8, 2022 23:53
@langermank langermank requested a review from simurai June 8, 2022 23:53
@changeset-bot
Copy link

changeset-bot bot commented Jun 8, 2022

🦋 Changeset detected

Latest commit: 190f9ee

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@langermank langermank temporarily deployed to github-pages June 9, 2022 00:00 Inactive
@langermank langermank temporarily deployed to github-pages June 11, 2022 00:42 Inactive
@camertron camertron merged commit f1b3e55 into main Jun 17, 2022
@camertron camertron deleted the autocomplete-form-fixes branch June 17, 2022 21:44
@primer-css primer-css mentioned this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants