Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppFrame component #2147

Merged
merged 5 commits into from
Jul 1, 2022
Merged

AppFrame component #2147

merged 5 commits into from
Jul 1, 2022

Conversation

vdepizzol
Copy link
Contributor

@vdepizzol vdepizzol commented Jul 1, 2022 •
edited
Loading

AppFrame is a thin wrapper that holds the page together, while making sure that the page's global footer is always visible "after the fold". This guarantees that loading states won't show the footer temporarily, and allows the footer to include richer interactions without obfuscating or competing with the page contents.

Features

  • Accessible navigation with "Skip to content"-style anchors
  • Unopinionated generic slots/regions for:
    • header
    • subheader
    • body
    • footer

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@vdepizzol vdepizzol requested a review from a team as a code owner July 1, 2022 18:35
@vdepizzol vdepizzol requested a review from langermank July 1, 2022 18:35
@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 67efaa3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vdepizzol vdepizzol temporarily deployed to github-pages July 1, 2022 18:40 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview July 1, 2022 18:41 Inactive
@vdepizzol vdepizzol temporarily deployed to github-pages July 1, 2022 19:00 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview July 1, 2022 19:01 Inactive
langermank
langermank approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny comment on the missing fallback, otherwise looks good!

src/layout/app-frame.scss Outdated Show resolved Hide resolved
src/layout/app-frame.scss Outdated Show resolved Hide resolved
src/layout/app-frame.scss Show resolved Hide resolved
@vdepizzol vdepizzol mentioned this pull request Jul 1, 2022
Closed
6 tasks
vdepizzol and others added 2 commits July 1, 2022 12:33
@vdepizzol @langermank
Update src/layout/app-frame.scss
e30c0f1 
Co-authored-by: Katie Langerman <langermank@github.com>
@vdepizzol
Use tokens
31c82f4
@github-actions github-actions bot temporarily deployed to Storybook Preview July 1, 2022 19:40 Inactive
@vdepizzol vdepizzol temporarily deployed to github-pages July 1, 2022 19:44 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview July 1, 2022 19:44 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview July 1, 2022 19:54 Inactive
@vdepizzol vdepizzol merged commit 9dd2a49 into main Jul 1, 2022
@vdepizzol vdepizzol deleted the vd/AppFrame branch July 1, 2022 20:00
@primer-css primer-css mentioned this pull request Jul 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langermank langermank langermank approved these changes

Assignees
No one assigned
Labels
minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vdepizzol @langermank