Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete item selected state #2177

Merged
merged 4 commits into from
Jul 28, 2022
Merged

Conversation

langermank
Copy link
Contributor

What are you trying to accomplish?

Quick patch to use the navActive state for aria-selected in the case of Autocomplete items.

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@langermank langermank requested a review from a team as a code owner July 28, 2022 00:45
@langermank langermank requested a review from jonrohan July 28, 2022 00:45
@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2022

🦋 Changeset detected

Latest commit: 1f2506a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to Storybook Preview July 28, 2022 00:51 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview July 28, 2022 00:52 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview July 28, 2022 01:05 Inactive
@langermank langermank merged commit add769c into main Jul 28, 2022
@langermank langermank deleted the actionlist-item-autocomplete-take2 branch July 28, 2022 01:06
@primer-css primer-css mentioned this pull request Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants