Remove outline reset of .SelectMenu-closeButton

[imjohnbo]

What are you trying to accomplish?

The current .SelectMenu-closeButton focus state is nearly hidden, even to the keenest of users. An outline state was recommended by @edokoa. This PR removes the outline reset to let keyboard users see an outline around .SelectMenu-closeButton when focused.

Before

selectmenu_closebutton_focus.mp4

After

selectmenu_closebutton_focus_fixed.mp4

What approach did you choose and why?

Removing the outline as suggested by @langermank 🙏

What should reviewers focus on?

Nothing especially tricky! 😄

Can these changes ship as is?

• Yes, this PR does not depend on additional changes. 🚢

[changeset-bot]

🦋 Changeset detected

Latest commit: 1d873fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/css	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[simurai]

I think the "after video" shows each item also getting the blue outline, but the change seems only to affect the close button?

Screen.Recording.2022-08-24.at.16.52.46.mov

Anyways, I think that's good for now. Thanks. 🙇

[imjohnbo]

Thanks @simurai!

I think the "after video" shows each item also getting the blue outline, but the change seems only to affect the close button?

Right you are. That was unintentional from devtool fiddling, but the change just merged should only affect SelectMenu-closeButtons. 🙇