Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Overlay easing animation #2269

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Fix Overlay easing animation #2269

merged 2 commits into from
Sep 30, 2022

Conversation

vdepizzol
Copy link
Contributor

@vdepizzol vdepizzol commented Sep 30, 2022

Slide-in overlays should have an ease-out animation. This PR fixes this, using values from an animation design token proposal: https://github.com/github/primer/issues/1026 (link only available for hubbers)

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@vdepizzol vdepizzol requested a review from a team as a code owner September 30, 2022 17:53
@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2022

🦋 Changeset detected

Latest commit: d7e6852

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vdepizzol vdepizzol temporarily deployed to github-pages September 30, 2022 18:01 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview September 30, 2022 18:01 Inactive
Copy link
Contributor

@langermank langermank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions github-actions bot temporarily deployed to Storybook Preview September 30, 2022 18:13 Inactive
@vdepizzol vdepizzol merged commit 27266fc into main Sep 30, 2022
@vdepizzol vdepizzol deleted the overlay-easing-fix branch September 30, 2022 18:24
@primer-css primer-css mentioned this pull request Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants