-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Noto Sans
to the body font stack
#2300
Conversation
To better support Linux.
🦋 Changeset detectedLatest commit: d451229 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Awesome! 🎉 🎉 Side note: we may also have to update this on Primer React and Primer Primitives (which should be used soon as a reference for both implementations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 adding this to Primitives!
> Hmm this appears to be a bug-by-design in the way Linux handles certain fonts like helvetica: chakra-ui/chakra-ui#2314 . Shipped a fix that specifies a Linux built-in font first: primer/css#2300 . Let me know if this works.
What are you trying to accomplish?
This adds
Noto Sans
to the$body-font
stack. I think the break down will be something like:-apple-system
for Safari + Firefox on macOSBlinkMacSystemFont
for Chrome on macOSSegoe UI
for WindowsNoto Sans
for Linux ✨ new ✨Helvetica
as legacy fallbackArial
as legacy fallbacksans-serif
as a system fallbackApple Color Emoji
+Segoe UI Emoji
for emojisWhat approach did you choose and why?
Adding
Noto Sans
should improve alignment issues on Linux. See #1209.What should reviewers focus on?
If anyone is on Linux and wants to test the new font stack, you could use the following in DevTools:
Can these changes ship as is?
Noto Sans
to the font stack primitives#385