Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upper-roman and upper-alpha list types #2305

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

vdepizzol
Copy link
Contributor

@vdepizzol vdepizzol commented Nov 7, 2022

Fixes https://github.com/github/primer/issues/1376

What are you trying to accomplish?

Adds support for upper-alpha and upper-roman in ordered lists.

Question: Is this stylesheet shared by React instances?

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@vdepizzol vdepizzol requested a review from a team as a code owner November 7, 2022 17:10
@vdepizzol vdepizzol requested a review from langermank November 7, 2022 17:10
@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2022

🦋 Changeset detected

Latest commit: cbf2b58

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vdepizzol vdepizzol temporarily deployed to github-pages November 7, 2022 17:16 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview November 7, 2022 17:16 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview November 15, 2022 20:38 Inactive
@vdepizzol vdepizzol merged commit 12355f8 into main Nov 16, 2022
@vdepizzol vdepizzol deleted the vdepizzol/upper-alpha-roman-lists branch November 16, 2022 20:42
@primer-css primer-css mentioned this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants