Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Checkbox/Radio border contrast #2316

Merged
merged 4 commits into from
Nov 18, 2022

Conversation

langermank
Copy link
Contributor

What are you trying to accomplish?

Before After
checkbox with low contrast border checkbox with high contrast border
checkbox with low contrast border checkbox with high contrast border

For comparison, in some browsers the default styles have more contrast than our Primer border color. So historically we have likely always had a mismatch of border colors between input fields and checkbox/radio.

Browser default checkbox next to a Primer input field

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@langermank langermank requested a review from a team as a code owner November 18, 2022 15:57
@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2022

🦋 Changeset detected

Latest commit: 0223f3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/css Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to Storybook Preview November 18, 2022 16:04 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview November 18, 2022 16:06 Inactive
Copy link
Contributor

@vdepizzol vdepizzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉

@github-actions github-actions bot temporarily deployed to Storybook Preview November 18, 2022 23:46 Inactive
@langermank langermank merged commit f3acb2b into main Nov 18, 2022
@langermank langermank deleted the higher-contrast-radio-checkbox branch November 18, 2022 23:50
@primer-css primer-css mentioned this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants