Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import FormControl and Overlay from PVC #2343

Merged
merged 3 commits into from
Dec 9, 2022
Merged

Import FormControl and Overlay from PVC #2343

merged 3 commits into from
Dec 9, 2022

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Dec 8, 2022 •
edited
Loading

What are you trying to accomplish?

Follow-up to #2326 and part of https://github.com/github/primer/issues/1444.

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2022

⚠️ No Changeset found

Latest commit: 116df8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to Storybook Preview December 8, 2022 08:01 Inactive
@simurai simurai marked this pull request as ready for review December 8, 2022 08:06
@simurai simurai requested a review from a team as a code owner December 8, 2022 08:06
@simurai simurai merged commit 4272e5e into main Dec 9, 2022
@simurai simurai deleted the import_from_pvc/overlay-formcontrol branch December 9, 2022 01:17
@simurai simurai mentioned this pull request Dec 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximedegreve maximedegreve maximedegreve approved these changes

@rezrah rezrah Awaiting requested review from rezrah rezrah was automatically assigned from primer/css-reviewers

@jonrohan jonrohan Awaiting requested review from jonrohan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simurai @maximedegreve