Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #2461 default selection color #2470

Merged
merged 2 commits into from
Jun 23, 2023
Merged

Revert #2461 default selection color #2470

merged 2 commits into from
Jun 23, 2023

Conversation

langermank
Copy link
Contributor

@langermank langermank commented Jun 22, 2023 •
edited
Loading

What are you trying to accomplish?

Reverts #2461

This selector seems risky and we think is only a bug for a small amount of users impacted by a Chrome feature flag.

What approach did you choose and why?

Delete the code.

What should reviewers focus on?

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@langermank langermank requested a review from a team as a code owner June 22, 2023 21:34
@langermank langermank requested a review from rezrah June 22, 2023 21:34
@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2023

⚠️ No Changeset found

Latest commit: af13ae1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot temporarily deployed to Storybook Preview June 22, 2023 21:41 Inactive
@github-actions github-actions bot temporarily deployed to Storybook Preview June 22, 2023 21:41 Inactive
@langermank langermank merged commit 03e1a26 into main Jun 23, 2023
@langermank langermank deleted the revert-selection-selector branch June 23, 2023 01:36
@primer-css primer-css mentioned this pull request Jun 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simurai simurai simurai approved these changes

@rezrah rezrah Awaiting requested review from rezrah rezrah was automatically assigned from primer/css-reviewers

Assignees
No one assigned
Labels
patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langermank @simurai