Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove -webkit-text-decoration-skip override #320

Merged
merged 1 commit into from
Nov 8, 2017
Merged

remove -webkit-text-decoration-skip override #320

merged 1 commit into from
Nov 8, 2017

Conversation

antons
Copy link
Contributor

@antons antons commented Aug 18, 2017

normalize.css introduced -webkit-text-decoration-skip: objects for the sake of consistency. I propose to revert it, because:

  1. It breaks iOS and macOS platform conventions: underlines are always drawn with “ink” style in native text views.
  2. It’s a step back for web typography. Apple intentionally set the browser default to “ink” to make underlined text more readable.
  3. The lack of this rule doesn’t affect other browsers, but its presence is harmful.

@broccolini mentioned that GitHub uses a fork of normalize.css. I originaly noticed the issue on GitHub, and it’s where I hope to see it reverted the most.

@broccolini
Copy link
Member

Thanks for the pr @antons! We'll need to test this in GitHub first before pulling into a primer release, we'll comment back here as to how that goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants