Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style buttons as selected on <details open> #346

Merged
merged 2 commits into from
Sep 22, 2017
Merged

Style buttons as selected on <details open> #346

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be74c71
Make selected state work on opening <details>
muan Sep 13, 2017
af4e61b
Merge branch 'dev' into muan/details-open
shawnbot Sep 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions modules/primer-support/lib/mixins/buttons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@
}

&:active,
&.selected {
&.selected,
[open] > & {
background-color: darken(desaturate($bg, 10%), 6%);
background-image: none;
border-color: rgba($black, 0.35); // repeat to avoid shift on click-drag off of button
Expand Down Expand Up @@ -54,7 +55,8 @@
}

&:active,
&.selected {
&.selected,
[open] > & {
background-color: darken(mix($bg, $bg2, 50%), 7%);
background-image: none;
border-color: $black-fade-50; // repeat to avoid shift on click-drag off of button
Expand Down Expand Up @@ -99,7 +101,8 @@
}

&:active,
&.selected {
&.selected,
[open] > & {
color: $text-white;
background-color: darken($color, 5%);
background-image: none;
Expand Down Expand Up @@ -129,7 +132,8 @@

&:hover,
&:active,
&.selected {
&.selected,
[open] > & {
color: $bg-color;
background-color: $text-color;
background-image: none;
Expand Down