README Improvements: Added sh to npm commands
#386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added bash after the three ` so it can match the style of the rest of the commands in the README files.
agisilaos
changed the title
bash to npm commandssh to npm commands
jonrohan
reviewed
Feb 28, 2018
| @@ -0,0 +1,62 @@ | |||
|
|
|||
There was a problem hiding this comment.
I'm going to pull this into 10.4.0. Can you remove this file (primer-cards was deleted) and update for any new modules?
There was a problem hiding this comment.
Will do @jonrohan! Thank you for the heads up!
emplums
reviewed
May 9, 2018
| ``` | ||
| $ npm install --save primer | ||
| >>>>>>> master:modules/primer/README.md |
There was a problem hiding this comment.
Looks like there's a merge conflict here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked and I saw that the snippets regarding
npmandterminalin the README files of the modules didn't haveshspecified likeHTMLcode snippets do.I added the word bash after the three ` so it can match the style of the rest of the commands in the README files of the modules. This way the files can be consistent in terms of style. Let me know what you think :)
/cc @primer/ds-core