Button color contrast improvements #418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some quick fixes to address color accessibility issues reported in https://github.com/github/github/issues/82929
<i>
tag in this way but unsure of how much work it would be to update in github/github so may need to follow up on this. Aside from targetting a type selector in an unusual way, we also can't guarantee that the resulting color will pass contrast in other color combinations.0.3
to0.4
- this isn't really a fix, just a slight improvement. Default focus outlines don't pass color contrast so it's not something I've considered before, however the default is noticeably darker and people still need to see it (for example if you used a keyboard rather than a mouse due to motor control issues). Having the same alpha transparency for every color isn't necessarily the best approach either because some hues have more range than other which will affect their perceived lightness. Coupled by the fact that our green is too light at the moment, the focus is still very light. I'll follow up with another pass that will either address the green color or de-couple the mixin for focus from the hue./cc @primer/ds-core