Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding stories from markdown for the other modules that didn't have any stories #427

Merged
merged 3 commits into from
Jan 13, 2018

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Jan 9, 2018

I went through the rest of our modules and added the storiesFromMarkdown parser to read in all of the code snippets.

The approval I'm looking for here is if the titles I picked for the code snippets need any improvements. I followed what the header said and tried to make it consistent with previous story naming.

As a small bonus in this pr, I added the version number of primer to the storybook title, so now it looks like this [ Primer v10.2.0 ][ ⌘ ]

Copy link
Member

@broccolini broccolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good except for TableObject lists documentation in the nav, if it's not too much effort to fix that in the docs that would be rad. If not, no worries, we can address later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants