-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .BtnGroup-parent, deprecate .BtnGroup-form #522
Conversation
I like this change a lot. It's something we noticed when attempting to re-implement the Merge pull request button from the merge box in primer-react, too. This is definitely a breaking change, so we'd need to queue up removal for v11 in #498. In the meantime, we can call out the deprecation with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I agree with @shawnbot we should add a deprecation warning as part of this PR if possible! 💖
Regarding the dev
branch, we've decided to get rid of it, and compare directly against our release branches instead. It's not in the documentation because we figured ds-core could be in charge of updating base branches, but in practice it feels a bit awkward 🤔 I'll think on that and update the docs accordingly!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful, thanks @muan! ❤️
dev
branch for me to compare againstAnyways this PR adds
.BtnGroup-parent
and keeps.BtnGroup-form
for backwards compatibility.parent
is a more generic name since this class can be used on more than just<form>
. I had to use it on<details>
a few times already.Is this OK? is there more we need to do for class name deprecation?
🌹