Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run script/check-versions after testing #555

Merged
merged 1 commit into from
Aug 2, 2018

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Aug 2, 2018

This should catch dependency version mismatches, @emplums. Let's see what happens with this PR on Travis. 🤞

I'm trying to think of an instance of when you'd need CI to pass with version mismatches. If anyone can think of one, we should have this short-circuit with something like:

script/check-versions || exit 0

Copy link
Contributor

@emplums emplums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants