Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dotcom installs, better script/check-versions reporting #593

Merged
merged 2 commits into from
Nov 13, 2018

Conversation

shawnbot
Copy link
Contributor

This does a couple of things to get installations of alpha release working in github/github again:

  1. Removes all of the package-specific package-lock.json files (but keeps the top-level one)

  2. Removes peerDependencies fields for primer-marketing-buttons and primer-popover, both of which were causing headaches

  3. Improves the script/check-versions script:

    • It now recognizes file: version specifiers
    • It reports all of the version mismatches at once, rather than bailing on the first one

These commits are cherry-picked from #573, and I've confirmed that they solve the issues with both CSS builds and licensing checks in github/github when you install it with something like:

pushd ~/primer/primer
primer="$(jq -r .version modules/primer/package.json)"
config="$(jq -r .version tools/stylelint-config-primer/package.json)"
commit="$(git rev-parse --short HEAD)"
popd
bin/npm install \
  "primer@$primer.alpha-$commit" \
  "stylelint-config-primer@$config.alpha-$commit"

@shawnbot shawnbot requested review from jonrohan and emplums October 25, 2018 23:42
Copy link
Member

@jonrohan jonrohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't think of any reason this wouldn't work. Let's try it and fix if we run into problems 👍

@shawnbot shawnbot merged commit c9961ab into release-10.10.0 Nov 13, 2018
@shawnbot shawnbot deleted the fix-dotcom-install branch November 13, 2018 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants