Add overrides for counters in our buttons #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Darken for just a tad more contrast against the button background | ||
| .counter { | ||
| background-color: #ddd; |
There was a problem hiding this comment.
Color literals like #ddd should only be used in variable declarations; they should be referred to via variable everywhere else.
| // Darken for just a tad more contrast against the button background | ||
| .counter { | ||
| text-shadow: none; | ||
| background-color: #ddd; |
There was a problem hiding this comment.
Color literals like #ddd should only be used in variable declarations; they should be referred to via variable everywhere else.
|
Merged master and add some docs to show the counters in buttons. I'm not super stoked on the aesthetics overall, but it addresses the glaring issues we have right now.
|
Conflicts: css/.primer-stats.md css/primer.css
mdo
added a commit
that referenced
this pull request
Mar 30, 2015
Add overrides for counters in our buttons
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #60.