Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin npm-run-all@4.1.5 #615

Merged
merged 1 commit into from
Nov 29, 2018
Merged

pin npm-run-all@4.1.5 #615

merged 1 commit into from
Nov 29, 2018

Conversation

shawnbot
Copy link
Contributor

This removes our indirect dependency on event-stream and flatmap-stream, the latter of which was recently compromised and removed from npm, breaking our CI builds. Here's where it came from:

primer/primer
└─┬ npm-run-all@4.1.3
  └─┬ ps-tree@1.1.0
    └─┬ event-stream@3.3.6
      └── flatmap-stream@0.1.2 

Note: npm-run-all is a dependency of the top-level monorepo package.json, and is not included in any of our published packages.

@shawnbot shawnbot requested review from jonrohan and emplums November 29, 2018 18:17
@shawnbot shawnbot changed the base branch from master to release-10.10.2 November 29, 2018 18:34
@shawnbot shawnbot merged commit 1105321 into release-10.10.2 Nov 29, 2018
@shawnbot shawnbot deleted the flatmap-stream branch November 29, 2018 18:34
@shawnbot shawnbot mentioned this pull request Nov 29, 2018
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant