Remove github/github-specific CSS #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For components like our image uploader, previewable forms, and issue/PR composers
|
Honestly, I doubt a lot of people would have dived into the CSS to see which classes they can use - people usually just check out the docs and go from there. Since this is CSS that's really specific to GitHub, I don't think anyone would have used it, had they even found it in the first place. I feel like you can get rid of this stuff with a minor version bump instead of a major one. |
|
👍 for removing undocumented CSS with a minor version bump. |
Closed
|
Can we make this a minor version bump (v2.1.0) since it changes functionality and it's not just bug fixes? |
|
Yup! |
|
Awesome thanks. 😄 |
|
Isn't this github specific too? https://github.com/primer/primer/blob/master/scss/_blankslate.scss#L75-L96 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an oversight on our end. We've got CSS in Primer with no plans to document or support those components for the open source community (not yet at least). Until then, we should remove these things entirely. This includes CSS for components like our image uploader, previewable forms, and issue/PR composers.
More details forthcoming. I'm unsure if this really should require a major version bump—it is removing code, and that's a breaking change—but this was never intended to ship.