Fix Box row top border #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miguelsolorio
approved these changes
Feb 8, 2019
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/primer/primer-css/mxrbhzzh4 |
simurai
approved these changes
Feb 27, 2020
There was a problem hiding this comment.
👋 I reverted "add border top for first row" 902f82a because there was still an issue with .Box-row--focus-gray.
Just enabling the top border on any .Box-row 7b0d4b8 seems to work. But there are so many combinations, it's hard to tell. 🤷♂ At least our docs now show a top border for all examples and there doesn't seem to be any double borders. 🤞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the top border for .Box--row elements.
/cc @primer/ds-core
Fixes #669