-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UnderlineNav overflow #684
Conversation
This appears to be working:
|
@ampinsk thanks, that's helpful! I'm going to revert that commit. |
…av-body" This reverts commit 43fd5ce.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm! Once this ships I will remove the custom css I shamefully added here 😬
Welp, this turns out not to have been a good change after all. I tried a couple of things in the inspector and failed. I think getting the underline to overlap the border is going to require some more work, so in the meantime @ampinsk, are you okay with nixing the |
Yeah that's fine! It's a small detail so if it's a big headache we should nix it 😄 |
This makes some tweaks to the UnderlineNav component:
overflow-x: auto
for horizontal scrolling, andoverflow-y: hidden
to prevent vertical scrolling.Removes 1px clipping viamargin-bottom: -1px
on.UnderlineNav-body
(because: why?)I'm requesting reviews from folks who have lots of experience with this component. Thanks!