Remove "prepare" npm script that runs "dist" #718
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for one aspect of #715: if a repo/app/project uses a different version of Node than you've used to run
npm install
in this repo, runningnpm link
will fail because it will attempt to build the CSS using a node-sass binary for the wrong version of Node.So instead of running
dist
in ourprepare
script (which goes away), we rundist
in thenow-build
script. I've tested this in dot-com and confirmed thatbin/npm link ../../primer/css
works after having runnpm install
in this repo with a different version of Node. ✨