Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent failed Storybook publishing from breaking the build #728

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

shawnbot
Copy link
Contributor

This runs npm run publish-storybook with --silent to suppress output, and echos a warning about failure if it doesn't exit cleanly.

@shawnbot shawnbot mentioned this pull request Mar 14, 2019
10 tasks
@simurai
Copy link
Contributor

simurai commented Mar 22, 2019

Ohh.. shoot. Sorry, I forgot to merge this PR before releasing 12.2.1. 😞 I'll add it to 12.2.2.

simurai added a commit that referenced this pull request Mar 22, 2019
Move #728 to `12.2.2` since it wasn't merged into `12.2.1`.
simurai added a commit that referenced this pull request Mar 22, 2019
Move #728 to `12.2.2` since it wasn't merged into `12.2.1`.
@simurai simurai mentioned this pull request Mar 22, 2019
8 tasks
@simurai simurai changed the base branch from release-12.2.1 to release-12.2.2 March 22, 2019 09:21
@shawnbot shawnbot merged commit c7fd221 into release-12.2.2 Apr 5, 2019
@shawnbot shawnbot deleted the storybook-publish-fix branch April 5, 2019 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants