Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating bower.json ignore files #74

Merged
merged 2 commits into from
Mar 29, 2015
Merged

Updating bower.json ignore files #74

merged 2 commits into from
Mar 29, 2015

Conversation

jonrohan
Copy link
Member

We're no longer using a script directory, and we have a few other unnecessary files.

@mdo @primer/owners

We're no longer using a script directory, and we have a few other unnecessary files.

Pull Request:master
@jonrohan jonrohan added the docs label Mar 29, 2015
@jonrohan jonrohan added this to the v2.0.3 milestone Mar 29, 2015
@jasonlong
Copy link
Contributor

👍 Makes sense to me.

@mdo
Copy link
Contributor

mdo commented Mar 29, 2015

Just need to sign that CLA @jonrohan :D.

@jonrohan
Copy link
Member Author

lol, I thought I did. So I did again.

jonrohan added a commit that referenced this pull request Mar 29, 2015
Updating bower.json ignore files
@jonrohan jonrohan merged commit 160bd8e into master Mar 29, 2015
@jonrohan jonrohan deleted the bower_ignores branch March 29, 2015 21:13
@mdo
Copy link
Contributor

mdo commented Mar 29, 2015

Hah, yeah, I think we've got some kinks to work out in the CLA stuff. Biggest one I've seen thus far is that sometimes it's not firing off for folks on push alone. I updated the hook to fire when adding labels and what not though, so if you don't see a second CI check, just change the label.

@mdo mdo mentioned this pull request Mar 29, 2015
@bkeepers
Copy link

Biggest one I've seen thus far is that sometimes it's not firing off for folks on push alone.

Please ping me if you see it not firing. The webhook was mis-configured last Friday, but I fixed it Saturday morning. If there have been any PRs that don't have a status since then, it's a bug and needs to be fixed.

I updated the hook to fire when adding labels and what not though, so if you don't see a second CI check, just change the label.

The app ignores everything except the pull_request event, which is fired whenever a PR is "synced" (created, pushed, etc). I'm not sure if changing the label kicks that off, but having the label event enabled won't do anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants