Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix table of contents instances #762

Merged
merged 8 commits into from
May 22, 2019
Merged

Fix table of contents instances #762

merged 8 commits into from
May 22, 2019

Conversation

emplums
Copy link
Contributor

@emplums emplums commented Apr 22, 2019

This PR uses the remark/toc plugin for table of contents on documentation pages, instead of our Outline component.

@emplums emplums requested a review from shawnbot April 22, 2019 22:07
shawnbot
shawnbot reviewed Apr 23, 2019
View reviewed changes
docs/markdown.js Outdated Show resolved Hide resolved
@shawnbot shawnbot mentioned this pull request Apr 29, 2019
Merged
13 tasks
@shawnbot shawnbot changed the base branch from master to release-12.3.0 April 29, 2019 18:43
shawnbot
shawnbot approved these changes Apr 29, 2019
View reviewed changes
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! 🚀

@simurai
Copy link
Contributor

simurai commented May 1, 2019

Looks like this didn't make it. I'll switch the base branch back to master.

@simurai simurai changed the base branch from release-12.3.0 to master May 1, 2019 23:51
@shawnbot
Copy link
Contributor

shawnbot commented May 2, 2019

Thanks, @simurai. Let's see if updating the branch re-runs actions and makes everything green. If so, we can merge this right to master.

simurai
simurai previously requested changes May 3, 2019
View reviewed changes
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this on now.sh and it seems that the "Table of Contents" links don't work. I think it's because the links in the toc are lowercase, but the IDs on the page are uppercase.

@emplums emplums requested a review from simurai May 7, 2019 21:49
@shawnbot shawnbot changed the base branch from master to release-12.3.1 May 7, 2019 22:16
shawnbot
shawnbot approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! It's a little bit annoying that the sticky header covers up most of the titles when you link to them, but at least the links work now! 🚀

@shawnbot shawnbot changed the base branch from release-12.3.1 to master May 9, 2019 20:26
@shawnbot shawnbot changed the base branch from master to release-12.4.1 May 22, 2019 23:40
@shawnbot shawnbot merged commit 53b7aa0 into release-12.4.1 May 22, 2019
@shawnbot shawnbot deleted the fix-toc branch May 22, 2019 23:41
@shawnbot shawnbot mentioned this pull request May 22, 2019
Merged
13 tasks
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
This was referenced Dec 15, 2022
Open
Open
Open
This was referenced Dec 23, 2022
Open
Open
Open
Open
Open
This was referenced Dec 31, 2022
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Jan 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnbot shawnbot shawnbot approved these changes

@simurai simurai Awaiting requested review from simurai

Assignees
No one assigned
Labels
Tag: Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emplums @simurai @shawnbot