Adding flex utilities for grow, order, and width #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stuff currently lives in |
shawnbot
previously approved these changes
Apr 23, 2019
shawnbot
dismissed
their stale review
We agreed this morning that this needs docs before being merged.
So it's grouped with the other flex properties
|
This pull request is automatically deployed with Now. |
simurai
reviewed
Jul 17, 2019
|
|
||
| .flex#{$variant}-order-1 { order: 1 !important; } | ||
| .flex#{$variant}-order-2 { order: 2 !important; } | ||
| .flex#{$variant}-order-none { order: inherit !important; } |
There was a problem hiding this comment.
I guess we could also use order: 0 instead of inherit to "remove" the order since 0 is the default value?
|
Added some documentation for...
/cc @jonrohan @shawnbot needs review/approval in case we want to make it part of 12.5.0. |
|
❤️ Thanks @simurai ! |
This was referenced Dec 22, 2022
This was referenced Dec 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull adds some flex utilities that I've been using to do some complex responsive stuff with the header.
What's added:
.flex-grow-0This was used in the blob header to get content to grow the columns. cc @emilybrick.flex-order-[1,2,none]this is useful for reordering columns at smaller sizes..width-autowe needed a way to turn off width: 100% at other breakpoints.TODO
After release:
components/flexbox.scssin .com./cc @primer/ds-core