-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Side Nav component #827
Side Nav component #827
Conversation
This pull request is automatically deployed with Now. |
Now there is just a single .SideNav component, but with 2 kinds of items.
After feedback from @zainkho + @emilybrick, here the sub nav with a white background. It's only done with
Maybe we can start "baking" it into the component once we have 1-2 more examples that use a sub nav. |
@simurai Oh interesting, so is the intention to always have a white background when the section expands to show level 2 items? I can see how that might help make what is active more clear. Will be good to see in dotcom and see how it feels! |
Co-Authored-By: Shawn Allen <shawn.allen@github.com>
Co-Authored-By: Shawn Allen <shawn.allen@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. Let's ship it! 🚀
This adds a "Side Nav" component to Primer CSS.
Basic markup
Utility and inline styles are optional and depend a bit where the component gets used. There could be modifier classes, but using utilities seems just as simple and allows for more flexibility without the maintenance cost.
Next steps
.com tests
Issue: https://github.com/github/design-systems/issues/624