-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toast component #831
Toast component #831
Conversation
This pull request is automatically deployed with Now. |
I think this is not needed anymore since the examples have a wrapper with `p-3`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Started to add a few comments, but then it got a bit messy. So here a PR with some tweaks: #834
Feel free to disagree if something is too opinionated. 😜
Oh.. one more thing. Should the An alternative might be that the component doesn't have to know where it is and it can be added in a wrapper like: <div class="position-fixed bottom-0 left-0">
<div class="Toast">...</div>
</div> The nice thing about that would be that if there are multiple Toasts at the same time, they would just start to stack on top of each other.. and we don't really have to bother about queuing them or calculate their individual positions. |
Co-Authored-By: Shawn Allen <shawn.allen@github.com>
`style="fill:currentcolor"` can be used for inline `<svg>`s
This is needed so that the Toast's margin's don't get collapsed and the example gets cropped.
Toasts v2.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go. 👍 We can always tweak it further after using it for a bit.
I branched off of this initial branch so that we could preserve all the styles @ampinsk explored, and just focus on the
block
style in this one.Updates in this branch:
To Do: