Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast component #831

Merged
merged 28 commits into from
Jul 17, 2019
Merged

Toast component #831

merged 28 commits into from
Jul 17, 2019

Conversation

emilybrick
Copy link
Contributor

@emilybrick emilybrick commented Jul 2, 2019

I branched off of this initial branch so that we could preserve all the styles @ampinsk explored, and just focus on the block style in this one.

Updates in this branch:

  • only using the "block" style (though, need to remove 'block' from the CSS classname as this should just become the default
  • removed buttons, so links + dismiss icons are the only actions
  • design tweaks

To Do:

  • swap border to inset box-shadow
  • use flex to align icon + text
  • make sure that if the text wraps to two lines and has a dismiss, the dismiss stays to the top right
  • define what should be built into the component (should animation be a modifier?)
  • merge into release branch for 12.5.0 /cc @shawnbot

Screenshot 2019-07-02 18 34 18

@vercel
Copy link

vercel bot commented Jul 2, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@simurai simurai mentioned this pull request Jul 3, 2019
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started to add a few comments, but then it got a bit messy. So here a PR with some tweaks: #834

Feel free to disagree if something is too opinionated. 😜

@simurai
Copy link
Contributor

simurai commented Jul 3, 2019

Oh.. one more thing. Should the .Toast component have by default a fixed bottom left position ?

An alternative might be that the component doesn't have to know where it is and it can be added in a wrapper like:

<div class="position-fixed bottom-0 left-0">
  <div class="Toast">...</div>
</div>

The nice thing about that would be that if there are multiple Toasts at the same time, they would just start to stack on top of each other.. and we don't really have to bother about queuing them or calculate their individual positions.

simurai and others added 7 commits July 16, 2019 01:36
Co-Authored-By: Shawn Allen <shawn.allen@github.com>
`style="fill:currentcolor"` can be used for inline `<svg>`s
This is needed so that the Toast's margin's don't get collapsed and the example gets cropped.
@vercel vercel bot temporarily deployed to staging July 17, 2019 02:19 Inactive
@simurai simurai changed the title Toasts v2 Toast component Jul 17, 2019
@simurai simurai marked this pull request as ready for review July 17, 2019 02:32
Copy link
Contributor

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go. 👍 We can always tweak it further after using it for a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants