BEM multi-word convention for Element or Modifier classes #836
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in #834 (comment).
Current
But we don't have a convention when Element or Modifier classes require two (or more) words.
Proposal
Alternatives
An alternative would be to use a
-
dash, like[Component]-close-button
or[Component]--extra-large
. But that might look like there are multiple nested elements. Or a modifier that has a unique child element. camelCase makes it more clear that the two words belong together./cc @primer/ds-core