-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding the Header component to primer #845
Conversation
This pull request is automatically deployed with Now. |
Co-Authored-By: Shawn Allen <shawn.allen@github.com>
Co-Authored-By: Shawn Allen <shawn.allen@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll update to use the flexbox utilities, but want to steer clear of adding to the link class, worried it will break a lot of things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, let's ship it! 🚀
This ports the recently created Header component from .com and adds documentation on it.
TODO:
@primer/octicons
css in the build process. There's style defaults `fill: currentColor;display: inline-block;vertical-align: text-bottom" that will fix a bug in the header example in the docs./cc @primer/ds-core