-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include GitHub's stylesheet.css in Storybook head #849
Conversation
A couple of Primer CSS components need GitHub's stylesheet.css to render correctly (I'm looking at you, dropdown). This adds it to the Storybook config directory along with preexisting stylesheet.js.
This pull request is automatically deployed with Now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this was a bug, but there might be a reason. @shawnbot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't appear to interfere with Storybook's styles since it's only rendered in previews. I think this works!
@vdepizzol I set the base branch for this to #854, but something just occurred to me: This probably won't work on primer.github.io/storybook because of github.com's CORS headers, which will prevent other domains from loading them in a browser. We might need to revive the mechanism that pulled down a static version of the github.com asset(s) to get this working, but for now it at least makes things easier for local development. |
@shawnbot that makes sense! I didn't know primer.github.io/storybook existed :) |
A couple of Primer CSS components need GitHub's stylesheet.css to render correctly (I'm looking at you, dropdown). This adds it to the Storybook config directory along with preexisting stylesheet.js.
This fixes this:
So it renders as this:
/cc @primer/ds-core