Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading toast spinner #852

Merged
merged 8 commits into from
Aug 5, 2019
Merged

Loading toast spinner #852

merged 8 commits into from
Aug 5, 2019

Conversation

emilybrick
Copy link
Contributor

@emilybrick emilybrick commented Jul 30, 2019

Earlier options:

screencast 2019-07-30 16-00-43
screencast 2019-07-30 16-00-18
screencast 2019-07-30 16-01-14

Thoughts:

Yellow feels like the right color here, but curious if others think it's a bad idea to keep the same style as the warning toast. I can see it working for pending and/or warning states.

  • landed on gray here as to not confuse this with a warning!

Leaning on the third option after chatting with @ashygee but open to discuss!

  • decided to stick with the circle style loader

Updated iteration:

Screenshot 2019-08-01 13 22 07

@vercel
Copy link

vercel bot commented Jul 30, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@emilybrick
Copy link
Contributor Author

The latest iteration is pushed up!
Based on feedback in our design systems design review last night, I'm opting for a gray background on the --loading modifier class:

screencast 2019-08-01 13-19-22

The loading circle is $gray-400, the rotating slice in the circle is white, and the background is $gray-600

@emilybrick
Copy link
Contributor Author

@shawnbot I think this is ready for review 🙏

@emilybrick emilybrick changed the title Test out spinners for loading toast Loading toast spinner Aug 5, 2019
@shawnbot shawnbot changed the base branch from master to release-12.6.0 August 5, 2019 20:28
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Can't wait to see it in use! Let's merge this to #854.

@emilybrick emilybrick merged commit 04099f8 into release-12.6.0 Aug 5, 2019
@shawnbot shawnbot mentioned this pull request Aug 6, 2019
11 tasks
@shawnbot shawnbot deleted the toast-spinner-test branch August 7, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants