-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report needless disables in CI, bump stylelint, tidy scripts #912
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://primer-css-git-needless-disables.primer.now.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, especially the remove needless disables script
This adds a call to
stylelint --report-needless-disables
to our lint test in Actions. I also bumped us tostylelint@^10.1.0
order to get the better output that @muan added in stylelint/stylelint#4071, and bumped a couple of other dev dependency versions while I was in there.I've also removed the
--unsafe-perm
flags from calls tonpm
in our Actions workflows, since those were only necessary when we hadpre
- andpost
- scripts. (We seem to have gotten rid of all of those — maybe both after migrating from Next to Gatsby, then to Doctocat?)TODO