Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SelectMenu docs #923

Merged
merged 2 commits into from
Oct 1, 2019
Merged

Improve SelectMenu docs #923

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60d3099
Remove type on <summary>
simurai Oct 1, 2019
4cc03fd
Remove aria-expanded
simurai Oct 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions docs/content/components/select-menu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Use a `<details>` element to toggle the Select Menu. The `<summary>` element can

```html live
<details class="details-reset details-overlay" open>
<summary class="btn" type="button" aria-haspopup="true" aria-expanded="true">
<summary class="btn" aria-haspopup="true">
Choose an item
</summary>
<div class="SelectMenu">
Expand Down Expand Up @@ -52,7 +52,7 @@ In case the Select Menu should be aligned to the right, use `SelectMenu right-0`
```html live
<div class="d-flex flex-justify-end position-relative">
<details class="details-reset details-overlay" open>
<summary class="btn" type="button" aria-haspopup="true" aria-expanded="true">
<summary class="btn" aria-haspopup="true">
Choose an item
</summary>
<div class="SelectMenu right-0">
Expand Down Expand Up @@ -89,7 +89,7 @@ Add a `.SelectMenu-icon .octicon-check` icon and it will show up when `aria-chec

```html live
<details class="details-reset details-overlay" open>
<summary class="btn" type="button" aria-haspopup="true" aria-expanded="true">
<summary class="btn" aria-haspopup="true">
Choose an item
</summary>
<div class="SelectMenu">
Expand Down Expand Up @@ -187,7 +187,7 @@ The list of items is arguably the most important subcomponent within the menu. B

```html live
<details class="details-reset details-overlay" open>
<summary class="btn" type="button" aria-haspopup="true" aria-expanded="true">
<summary class="btn" aria-haspopup="true">
Choose an item
</summary>
<div class="SelectMenu">
Expand Down Expand Up @@ -256,7 +256,7 @@ The Select Menu's list can be divided into multiple parts by adding a `.SelectMe

```html live
<details class="details-reset details-overlay" open>
<summary class="btn" type="button" aria-haspopup="true" aria-expanded="true">
<summary class="btn" aria-haspopup="true">
Choose an item
</summary>
<div class="SelectMenu">
Expand Down Expand Up @@ -297,7 +297,7 @@ Also consider adding a `.SelectMenu-footer` at the bottom. It can be used for ad

```html live
<details class="details-reset details-overlay" open>
<summary class="btn" type="button" aria-haspopup="true" aria-expanded="true">
<summary class="btn" aria-haspopup="true">
Choose an item
</summary>
<div class="SelectMenu SelectMenu--hasFilter">
Expand Down Expand Up @@ -359,7 +359,7 @@ Sometimes you need two or more lists of items in your Select Menu, e.g. branches

```html live
<details class="details-reset details-overlay" open>
<summary class="btn" type="button" aria-haspopup="true" aria-expanded="true">
<summary class="btn" aria-haspopup="true">
Choose an item
</summary>
<div class="SelectMenu SelectMenu--hasFilter">
Expand Down Expand Up @@ -410,7 +410,7 @@ A `SelectMenu-message` can be used to show different kind of messages to a user.

```html live
<details class="details-reset details-overlay" open>
<summary class="btn" type="button" aria-haspopup="true" aria-expanded="true">
<summary class="btn" aria-haspopup="true">
Choose an item
</summary>
<div class="SelectMenu">
Expand Down Expand Up @@ -447,7 +447,7 @@ When fetching large lists, consider showing a `.SelectMenu-loading` animation.

```html live
<details class="details-reset details-overlay" open>
<summary class="btn" type="button" aria-haspopup="true" aria-expanded="true">
<summary class="btn" aria-haspopup="true">
Choose an item
</summary>
<div class="SelectMenu SelectMenu--hasFilter">
Expand Down Expand Up @@ -499,7 +499,7 @@ Sometimes a Select Menu needs to communicate a "blank slate" where there's no co

```html live
<details class="details-reset details-overlay" open>
<summary class="btn" type="button" aria-haspopup="true" aria-expanded="true">
<summary class="btn" aria-haspopup="true">
Choose an item
</summary>
<div class="SelectMenu">
Expand Down