Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚚 Add Flash Banner #926

Merged
merged 2 commits into from
Oct 10, 2019
Merged

🚚 Add Flash Banner #926

merged 2 commits into from
Oct 10, 2019

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Oct 2, 2019 •
edited
Loading

This moves the .flash-banner styles from github/github to Primer CSS.

TODO

  • Add styles
  • Add documentation

TODO on .com

Tracking https://github.com/github/design-systems/issues/684

@vercel
Copy link

vercel bot commented Oct 2, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-css-git-flash-banner.primer.now.sh

@shawnbot
Copy link
Contributor

shawnbot commented Oct 3, 2019

FYI, I updated the tags to reflect that this is an enhancement (when adding things) vs. polish.

shawnbot
shawnbot approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @simurai I'll defer to you on whether you want to do this in 14.0 (#925) or in a new minor release (13.3?).

@shawnbot shawnbot mentioned this pull request Oct 4, 2019
Merged
19 tasks
@simurai
Copy link
Contributor Author

simurai commented Oct 4, 2019 •
edited
Loading

FYI, I updated the tags to reflect that this is an enhancement (when adding things) vs. polish.

Was wondering about that. It's not really new for dotcom users, but I guess it is new in Primer CSS. 👍 on treating it as an enhancement and get out it at least as a minor release.

@simurai simurai changed the base branch from master to release-14.0.0 October 4, 2019 04:49
@shawnbot
Copy link
Contributor

shawnbot commented Oct 7, 2019 •
edited
Loading

Let's move this to #935 so that we can get it out sooner than 14.0.0. 🚀

@shawnbot shawnbot changed the base branch from release-14.0.0 to release-13.1.0 October 7, 2019 18:19
@shawnbot shawnbot mentioned this pull request Oct 7, 2019
Merged
10 tasks
@simurai simurai merged commit 021d273 into release-13.1.0 Oct 10, 2019
@simurai simurai deleted the flash-banner branch October 10, 2019 04:29
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
This was referenced Dec 20, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnbot shawnbot shawnbot approved these changes

Assignees
No one assigned
Labels
minor release Tag: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simurai @shawnbot