-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert most ERB examples to HTML live #933
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://primer-css-git-convert-erb-to-html-live.primer.now.sh |
Oof, Pagehead is really borked. 😬 Maybe we just switch those all to ERB until we can sort out the octicon situation in those examples? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I really want to figure out a better solution for this that makes the examples more legible, but for now this works.
Ouuuu.. 🙈 right. For now, let's convert them to |
This replaces (almost) all
erb
examples withhtml live
. Mostly using<svg>
for Octicons.Not converted:
Concerns
It makes the code "busy" because the
<svg>
s can take up a lot of space. But maybe still better than not showing the example at all? 🤷♂ Also, this is just a stop-gap until we find a better solution:<svg>
s only take up a single line./cc @primer/ds-core
/ccc @keeran who kicked this off in Slack 🤗