Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert most ERB examples to HTML live #933

Merged
merged 13 commits into from
Oct 10, 2019

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Oct 7, 2019

This replaces (almost) all erb examples with html live. Mostly using <svg> for Octicons.

Not converted:

Concerns

It makes the code "busy" because the <svg>s can take up a lot of space. But maybe still better than not showing the example at all? 🤷‍♂ Also, this is just a stop-gap until we find a better solution:

/cc @primer/ds-core
/ccc @keeran who kicked this off in Slack 🤗

@vercel
Copy link

vercel bot commented Oct 7, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://primer-css-git-convert-erb-to-html-live.primer.now.sh

@shawnbot shawnbot changed the base branch from master to release-13.1.0 October 7, 2019 18:00
@shawnbot shawnbot mentioned this pull request Oct 7, 2019
10 tasks
@shawnbot
Copy link
Contributor

shawnbot commented Oct 7, 2019

Oof, Pagehead is really borked. 😬 Maybe we just switch those all to ERB until we can sort out the octicon situation in those examples?

Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I really want to figure out a better solution for this that makes the examples more legible, but for now this works.

@simurai
Copy link
Contributor Author

simurai commented Oct 10, 2019

Oof, Pagehead is really borked. 😬 Maybe we just switch those all to ERB until we can sort out the octicon situation in those examples?

Ouuuu.. 🙈 right. For now, let's convert them to svg too.

@simurai simurai merged commit f782dfc into release-13.1.0 Oct 10, 2019
@simurai simurai deleted the convert-erb-to-html-live branch October 10, 2019 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants