Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IssueLabel component #953

Merged
merged 3 commits into from
Oct 23, 2019
Merged

Add IssueLabel component #953

merged 3 commits into from
Oct 23, 2019

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Oct 22, 2019 •
edited
Loading

This adds the .IssueLabel component to Primer CSS.

Screen Shot 2019-10-22 at 10 21 36 PM

TODO

  • Add styles
  • Add documentation
  • Refactor?

TODO on dotcom

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented Oct 22, 2019 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/mzp7w6rvb
🌍 Preview: https://primer-css-git-issue-label.primer.now.sh

shawnbot
shawnbot reviewed Oct 22, 2019
View reviewed changes
Copy link
Contributor

@shawnbot shawnbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great as-is. There doesn't appear to be much to refactor here without changing how the labels look, which is probably best to do in a follow-up PR. I'll hold off on approving until you're ready to take it out of draft, though! ❤️

@simurai
Copy link
Contributor Author

simurai commented Oct 23, 2019

I was wondering about things like the fixed height: 20px; or line-height: 15px;. Or even merge .IssueLabel and Label. But also happy to look into that stuff another time, since our list is still long. 😅

Another thought is to use more of the em unit. So that labels adjust in size/padding automatically based on the font-size. Maybe something to consider with the refresh.

@simurai simurai marked this pull request as ready for review October 23, 2019 00:12
@simurai simurai requested a review from shawnbot October 23, 2019 00:13
@simurai simurai changed the base branch from master to release-13.2.0 October 23, 2019 00:14
@shawnbot shawnbot mentioned this pull request Oct 23, 2019
Merged
15 tasks
@shawnbot shawnbot merged commit 435abad into release-13.2.0 Oct 23, 2019
@shawnbot shawnbot deleted the issue-label branch October 23, 2019 16:34
@github-actions github-actions bot mentioned this pull request Nov 28, 2022
Open
This was referenced Dec 22, 2022
Open
Open
@github-actions github-actions bot mentioned this pull request Jan 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnbot shawnbot shawnbot approved these changes

Assignees
No one assigned
Labels
minor release Tag: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simurai @shawnbot