Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .radio-group component #979

Merged
merged 7 commits into from
Nov 19, 2019
Merged

Add .radio-group component #979

merged 7 commits into from
Nov 19, 2019

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Nov 8, 2019

This adds the .radio-group component from dotcom.

radio-group

📖 Docs Preview

TODO

  • Add styles from dotcom
  • Add documentation
  • Adjust spacing

TODO on dotcom

/cc @primer/ds-core

@vercel
Copy link

vercel bot commented Nov 8, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/ql4780xew
🌍 Preview: https://primer-css-git-radio-group.primer.now.sh

@simurai simurai changed the base branch from master to release-14.0.0 November 8, 2019 07:05
@simurai
Copy link
Contributor Author

simurai commented Nov 8, 2019

Refactor?

Was thinking of also making this a "checkbox group". Maybe without showing the checkboxes? For use cases where multiple selections should be possible:

checkbox-group

And would be nice if the radio/checkbox can also be inside the <label> so that it's not necessary to add these id and fors.

Maybe one day ™️ ?

@simurai
Copy link
Contributor Author

simurai commented Nov 18, 2019

Ok, changed the spacing to match the height (34px) of other inputs and buttons:

image

If we wanted to get rid of the "disables", we probably should change the height on all components that get used next to each other.

@simurai
Copy link
Contributor Author

simurai commented Nov 19, 2019

Awesome, thank you! #979 (comment)

Ok, I'll count this as a 👍 and merge it. 🚢

@simurai simurai merged commit 6fecbe2 into release-14.0.0 Nov 19, 2019
@simurai simurai deleted the radio-group branch November 19, 2019 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants